just: Check feature matrix in check#23
Open
ValuedMammal wants to merge 1 commit intobitcoindevkit:masterfrom
Open
just: Check feature matrix in check#23ValuedMammal wants to merge 1 commit intobitcoindevkit:masterfrom
check#23ValuedMammal wants to merge 1 commit intobitcoindevkit:masterfrom
Conversation
ValuedMammal
force-pushed
the
just_check_features
branch
from
fe9a2a2 to
d4bb2cb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The idea is to have a
cargo checkfor every feature configuration in thecheckrecipe.Notes to the reviewers
I felt that checking
--all-featuresdidn't really make sense here because the Bitcoin Core features aren't necessarily additive per se, they're more like mutually exclusive. I can see thatcorepc-nodedoes things slightly differently in that each Core version feature enables the previous one, and that's a possibility we could explore. Let me know what you think.